fix(modp2p): temporary disable quic #2837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wondertan
requested review from
renaynay,
vgonkivs,
distractedm1nd and
walldiss
as code owners
Wondertan
commented
Oct 11, 2023
Codecov Report
@@ Coverage Diff @@
## main #2837 +/- ##
==========================================
- Coverage 51.28% 51.20% -0.08%
==========================================
Files 168 168
Lines 10730 10744 +14
==========================================
- Hits 5503 5502 -1
- Misses 4747 4761 +14
- Partials 480 481 +1
|
distractedm1nd
previously approved these changes
Oct 12, 2023
walldiss
previously approved these changes
Oct 12, 2023
walldiss
reviewed
Oct 12, 2023
ramin
previously approved these changes
Oct 12, 2023
renaynay
previously approved these changes
Oct 13, 2023
Wondertan
added
area:core_and_app
Wondertan
dismissed stale reviews from renaynay, ramin, walldiss, and distractedm1nd
via
ed7c6f2
renaynay
approved these changes
Oct 13, 2023
distractedm1nd
approved these changes
Oct 13, 2023
5 tasks
Merged
Wondertan
added a commit
that referenced
this pull request
Nov 27, 2023
This reverts commit 17619db.
Wondertan
added a commit
that referenced
this pull request
Dec 13, 2023
Reverts disabled quic. We weren't able to reproduce [the issue](libp2p/go-libp2p#2591) since we first observed it, as well as quic released changes to address this. Even if the issue is there, I think it's more or less safe as we always have TCP as fallback
ramin
added a commit
that referenced
this pull request
Dec 20, 2023
A regular bump with multiple minor fixes as well broader optimizations like TCP eyeballing https://github.com/libp2p/go-libp2p/releases/tag/v0.32.0 It may also fix the issue behind #2837, but this has to be confirmed yet Co-authored-by: ramin <raminkeene@gmail.com>
renaynay
pushed a commit
to renaynay/celestia-node
that referenced
this pull request
Jan 15, 2024
A regular bump with multiple minor fixes as well broader optimizations like TCP eyeballing https://github.com/libp2p/go-libp2p/releases/tag/v0.32.0 It may also fix the issue behind celestiaorg#2837, but this has to be confirmed yet Co-authored-by: ramin <raminkeene@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disables QUIC by default yet allows to enable it with ENV var.
This is temporary and until libp2p/go-libp2p#2591 is investigated and fixed.
The current solution disables QUIC programmatically while we still keep writing in the config QUIC listen addresses by default. This removes the need for users to reinit their configs once we turn QUIC back by default.
This works perfectly fine on mocha.