fix: removing chainid from default store name for mainnet #2841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
distractedm1nd
requested review from
renaynay,
Wondertan,
vgonkivs and
walldiss
as code owners
distractedm1nd
force-pushed
the
mainnet-nodestore
branch
from
64db1ed
to
79a64f8
Compare
Wondertan
approved these changes
Oct 13, 2023
|
@jcstein should know about this. For mainnet, the directory format will be |
|
@distractedm1nd, if we are to keep it Mainnet internally, why wouldn't we keep it |
|
Mainnet has nothing to do w CHAINID, CHAINID is still "celestia" |
renaynay
approved these changes
Oct 13, 2023
|
thank you @distractedm1nd for the tag. confirming i will document celestia-node store paths for mainnet to be: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also part of #2823
Stacked on #2840