-
Notifications
You must be signed in to change notification settings - Fork 953
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(blob): extend blob struct with index field #3165
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3165 +/- ##
==========================================
+ Coverage 51.81% 52.23% +0.41%
==========================================
Files 178 179 +1
Lines 11286 11422 +136
==========================================
+ Hits 5848 5966 +118
- Misses 4930 4955 +25
+ Partials 508 501 -7 ☔ View full report in Codecov by Sentry. |
We should mark this API and proto breaking |
Looks like there are only new fields added, so it is backwards compatible. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Initial review of semantics
I know, but that's not the point. We need to mark it so that eiger team can react to this PR and update rust client respectively |
81d43aa
to
2e83726
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another semantical review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
another general comment, the code inside retrieve
is getting long/hairy and would benefit from some comments throughout.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last little comments/questions. Looking slightly better
5d5c3b6
to
37daa74
Compare
37daa74
to
6a35738
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please improve the PR description and add other secondary changes in this PR, like tracing
bf59da3
to
541d9cf
Compare
{
"id": 1,
"jsonrpc": "2.0",
"result": [
{
"namespace": "AAAAAAAAAAAAAAAAAAAAAAAAAAECAwQFBgcICRA=",
"data": "VGhpcyBpcyBhbiBleGFtcGxlIG9mIHNvbWUgYmxvYiBkYXRh",
"share_version": 0,
"commitment": "AD5EzbG0/EMvpw0p8NIjMVnoCP4Bv6K+V6gjmwdXUKU="
"index": 1
}
]
} |
|
What was done:
parser
entity that collects shares and transforms them to blob;