Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve: use errors.New to replace fmt.Errorf with no parameters #3206

Merged
merged 2 commits into from
Feb 26, 2024

Conversation

0x2d3c
Copy link
Contributor

@0x2d3c 0x2d3c commented Feb 24, 2024

Some parameterless errors should be using errors.New instead of fmt.Errorf

@github-actions github-actions bot added the external Issues created by non node team members label Feb 24, 2024
@ramin ramin added the kind:misc Attached to miscellaneous PRs label Feb 26, 2024
@ramin ramin enabled auto-merge (squash) February 26, 2024 10:17
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 52.71%. Comparing base (1809680) to head (b583a1a).
Report is 1 commits behind head on main.

Files Patch % Lines
share/eds/store_options.go 0.00% 3 Missing ⚠️
cmd/auth.go 0.00% 1 Missing ⚠️
cmd/rpc.go 0.00% 1 Missing ⚠️
core/fetcher.go 0.00% 1 Missing ⚠️
core/listener.go 0.00% 1 Missing ⚠️
das/daser.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3206      +/-   ##
==========================================
+ Coverage   51.92%   52.71%   +0.78%     
==========================================
  Files         178      178              
  Lines       11316     9317    -1999     
==========================================
- Hits         5876     4911     -965     
+ Misses       4942     3907    -1035     
- Partials      498      499       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ramin ramin merged commit 74b54e4 into celestiaorg:main Feb 26, 2024
25 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external Issues created by non node team members kind:misc Attached to miscellaneous PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants