-
Notifications
You must be signed in to change notification settings - Fork 931
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(state/coreAccessor): fix txResponse #3336
Conversation
4cf7caf
to
1f03448
Compare
1f03448
to
6e4e4d3
Compare
I tested this branch (version output for ref) and see the same logs as I did on #3304, on a successful grant-fee tx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good as a temporary workaround
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm okay with this temporary fix. We need a corresponding issue that tracks the core/app issue to make sure we do not forget it in node.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3336 +/- ##
==========================================
- Coverage 44.83% 44.60% -0.24%
==========================================
Files 265 273 +8
Lines 14620 15254 +634
==========================================
+ Hits 6555 6804 +249
- Misses 7313 7667 +354
- Partials 752 783 +31 ☔ View full report in Codecov by Sentry. |
has this been made? or does it still need to be made? |
Resolves #3322
Marshaling
TxResponse
fails becauseTxResponse.Tx
is not empty but does not contain respective codec for encoding using the standardjson.MarshalJSON()