-
Notifications
You must be signed in to change notification settings - Fork 925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactoring(cmd/state): remove submit-tx from cli #3348
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we have the doc PR lined up before we merge this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please mark as break
@vgonkivs
Oh i already did 😂 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3348 +/- ##
==========================================
- Coverage 44.83% 44.53% -0.31%
==========================================
Files 265 272 +7
Lines 14620 15230 +610
==========================================
+ Hits 6555 6782 +227
- Misses 7313 7655 +342
- Partials 752 793 +41 ☔ View full report in Codecov by Sentry. |
Addresses a TODO in #3345