chore(nodebuilder/das | pruner): Privatise samplingWindow
in DAS params, add Duration method to AvailabilityWindow
#3378
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While this isn't really a bug fix, it's more of a "UX" fix - I'm removing
SamplingWindow
from the node's config so that it doesn't confuse users to see "0ms" as the config value even though in practice it's 30 days.The reason there's a discrepancy is because we force the light sampling window in the DASer for light nodes in nodebuilder anyway so that config value is ignored regardless, meaning it does not need to be exposed.
Also adding
Duration()
method to return time.Duration instead of having to cast everywhere.