Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(shwap): Add cache file #3498

Merged
merged 8 commits into from
Jun 27, 2024
Merged

feat(shwap): Add cache file #3498

merged 8 commits into from
Jun 27, 2024

Conversation

walldiss
Copy link
Member

Add eds.Accessor to cache extended shares and proofs.

@walldiss walldiss added kind:feat Attached to feature PRs shwap labels Jun 17, 2024
@walldiss walldiss self-assigned this Jun 17, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jun 17, 2024

Codecov Report

Attention: Patch coverage is 63.95349% with 62 lines in your changes missing coverage. Please review.

Please upload report for BASE (shwap@c78f081). Learn more about missing BASE report.

Files Patch % Lines
store/file/cache_file.go 60.65% 38 Missing and 10 partials ⚠️
share/new_eds/axis_half.go 69.23% 4 Missing and 4 partials ⚠️
share/ipld/nmt_adder.go 57.14% 2 Missing and 1 partial ⚠️
store/file/proofs/proofs.go 81.81% 1 Missing and 1 partial ⚠️
header/headertest/fraud/testing.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             shwap    #3498   +/-   ##
========================================
  Coverage         ?   43.96%           
========================================
  Files            ?      289           
  Lines            ?    16753           
  Branches         ?        0           
========================================
  Hits             ?     7365           
  Misses           ?     8535           
  Partials         ?      853           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Wondertan
Copy link
Member

Needs rebase

store/file/cache_file.go Outdated Show resolved Hide resolved
store/file/cache_file.go Outdated Show resolved Hide resolved
store/file/cache_file.go Outdated Show resolved Hide resolved
store/file/cache_file.go Outdated Show resolved Hide resolved
store/file/cache_file.go Outdated Show resolved Hide resolved
store/file/proofs/proofs.go Outdated Show resolved Hide resolved
walldiss added 2 commits June 25, 2024 03:11
- rename inmemoryAxis
- don't embed Accessor
- move cache to eds pkg
Copy link
Member

@Wondertan Wondertan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better documentation!

share/ipld/proofs.go Show resolved Hide resolved
share/new_eds/proofs_cache.go Show resolved Hide resolved
@Wondertan
Copy link
Member

And needs rebase

@walldiss walldiss merged commit ab4f860 into celestiaorg:shwap Jun 27, 2024
27 checks passed
walldiss added a commit to walldiss/celestia-node that referenced this pull request Jul 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:feat Attached to feature PRs shwap
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants