misc(ci): detect breaking change to any .proto files or config fields in nodebuilder/**/config.go and add kind:break! #3568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramin
requested review from
renaynay,
Wondertan,
vgonkivs,
distractedm1nd,
walldiss and
cristaloleg
as code owners
|
Proto changes are not neccessary breaking, as there might be backwards compatibility support. Perhaps the motivation here is that it is easier to remember to remove unwanted breaking tag, than add one? |
renaynay
approved these changes
Jul 18, 2024
vgonkivs
approved these changes
Aug 9, 2024
walldiss
approved these changes
Aug 9, 2024
sebasti810
pushed a commit
to sebasti810/celestia-node
that referenced
this pull request
Aug 14, 2024
… in nodebuilder/**/config.go and add kind:break! (celestiaorg#3568)
walldiss
pushed a commit
to walldiss/celestia-node
that referenced
this pull request
Aug 21, 2024
… in nodebuilder/**/config.go and add kind:break! (celestiaorg#3568) (cherry picked from commit 73235c6)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
deep cut: fixes #1918
If we change a .proto file, or add/modify a field in nodebuilder/**/config.go (specifically a struct) then add a label
kind:break!on PR creationhard to test but you can see some of mine in the commit history. As it stands i've left this on PR open ONLY for now so if it does misbehave, we don't get stuck with a break label on sync/update. We can expand scope later.