New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(shwap): don't cache empty eds and close recent accessor #3608

Merged

Wondertan merged 1 commit into celestiaorg:shwap from walldiss:dont-cache-empty-eds

Jul 31, 2024

Member

walldiss commented Jul 31, 2024

No need to put in cache empty eds
in-mem accessor needs to be closed to release created reference in cache.


          don't cache empty eds and close recent accessor

6eda454

walldiss added kind:fix shwap labels

walldiss self-assigned this

walldiss requested review from renaynay, Wondertan, vgonkivs, distractedm1nd, ramin and cristaloleg as code owners

July 31, 2024 11:58

Wondertan approved these changes

View reviewed changes

Wondertan merged commit 9118b8e into celestiaorg:shwap

16 of 19 checks passed

Wondertan deleted the dont-cache-empty-eds branch

July 31, 2024 13:08

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Wondertan Wondertan approved these changes

renaynay Awaiting requested review from renaynay

vgonkivs Awaiting requested review from vgonkivs

distractedm1nd Awaiting requested review from distractedm1nd

ramin Awaiting requested review from ramin

cristaloleg Awaiting requested review from cristaloleg

Labels