refactor!(shwap/store): decouple Q1Q4 and ODS files #3643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wondertan
requested review from
renaynay,
vgonkivs,
distractedm1nd,
walldiss,
ramin and
cristaloleg
as code owners
Wondertan
force-pushed
the
shwap-decouple-files
branch
from
4cccb18 to
5a4dff4
Compare
|
One more optimization to do here is to open files lazily. However, that's not trivial, as we detect whether file is empty or not only while opening it and we can't open empty file lazily with ease. Options:
I am going with the last option. It's simple and optimizes for the more common case: ODS usage without Q4. The less common but still possible case where Q4 is used without ODS is not covered, but its less common(only for sampling) and might not worth additional complexity to handle it. |
Wondertan
force-pushed
the
shwap-decouple-files
branch
10 times, most recently
from
f08245d to
eb86046
Compare
This PR simplifies and cleans row/col read logic in preparation for ODS and Q1Q4 files decoupling. Mainly, it removes quadrant offset from calculations
Wondertan
force-pushed
the
shwap-decouple-files
branch
from
4746808 to
c59d96a
Compare
walldiss
reviewed
Aug 14, 2024
Makes ODS and Q4 distinct physical files with different extentions. Both files are hardlinked separately
Wondertan
force-pushed
the
shwap-decouple-files
branch
from
c59d96a to
a8c83e7
Compare
Treating empty file as an empty block can create issues for node operators and is a foot gun. To avoid this, we make empty file a proper file. Besides, we refresh empty file on start to ensure its consistent with canonical empty file kept in mem.
This yields additional 27% improvement on the Put operation for the store. The discrepancy seems to grow with the block size.
Wondertan
force-pushed
the
shwap-decouple-files
branch
from
a8c83e7 to
4ee148f
Compare
walldiss
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main goal of this PR is to decouple Q1Q4 and ODS files physically, so now there are two files
.odsand.q4. This is needed to fix and unblock trimming in #3620. Besides, this PR ends up shaving off another ~27% of times it take for Put.This PR is split into several commits that are independently reviewable and should be merged as so.
TODO: