feat(shwap/store): Add q4 trimming support in store #3680
Conversation
walldiss
force-pushed
the
shwap-archival-pruning
branch
from
4bbe418
to
833f194
Compare
walldiss
changed the title
walldiss
requested review from
renaynay,
Wondertan,
vgonkivs,
distractedm1nd and
cristaloleg
as code owners
walldiss
force-pushed
the
shwap-archival-pruning
branch
from
833f194
to
06b6535
Compare
| return | ||
| } | ||
| if ctx.Err() != nil { | ||
| ctx = context.Background() |
There was a problem hiding this comment.
So, always blocking? Maybe context.WithTimeout(context.Background(), time.Second) ?
There was a problem hiding this comment.
Good that you pointed out. We use common function to reset context in metrics everywhere else. I'll change how we do it in another PR.
There was a problem hiding this comment.
Agree. It may cause random hickups somewhere in the future that would be a nightmare to debug
walldiss
force-pushed
the
shwap-archival-pruning
branch
from
06b6535
to
d572276
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## shwap #3680 +/- ##
========================================
Coverage ? 46.63%
========================================
Files ? 314
Lines ? 17792
Branches ? 0
========================================
Hits ? 8298
Misses ? 8490
Partials ? 1004 ☔ View full report in Codecov by Sentry. |
store/store.go
Outdated
| @@ -305,51 +304,76 @@ func (s *Store) hasByHeight(height uint64) (bool, error) { | |||
| return exists(pathODS) | |||
| } | |||
|
|
|||
| func (s *Store) Remove(ctx context.Context, height uint64, datahash share.DataHash) error { | |||
| func (s *Store) RemoveAll(ctx context.Context, height uint64, datahash share.DataHash) error { | |||
There was a problem hiding this comment.
Let's name to RemoveODSQ4. Its not clear what All stands for.
Same for helpers methods and metrics.
store/store.go
Outdated
| @@ -33,7 +33,7 @@ const ( | |||
| var ErrNotFound = errors.New("eds not found in store") | |||
|
|
|||
| // Store is a storage for EDS files. It persists EDS files on disk in form of Q1Q4 files or ODS | |||
| // files. It provides methods to put, get and remove EDS files. It has two caches: recent eds cache | |||
| // files. It provides methods to put, get and removeAll EDS files. It has two caches: recent eds cache | |||
| return | ||
| } | ||
| if ctx.Err() != nil { | ||
| ctx = context.Background() |
There was a problem hiding this comment.
Agree. It may cause random hickups somewhere in the future that would be a nightmare to debug
No description provided.