Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(share/availability): Dont store q4 on archival #3751

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

walldiss
Copy link
Member

Avoid storing q4 for data outside of availability window

@codecov-commenter
Copy link

codecov-commenter commented Sep 19, 2024

Codecov Report

Attention: Patch coverage is 25.53191% with 35 lines in your changes missing coverage. Please review.

Please upload report for BASE (shwap@2c67306). Learn more about missing BASE report.

Files with missing lines Patch % Lines
store/store.go 20.00% 23 Missing and 1 partial ⚠️
store/metrics.go 20.00% 4 Missing ⚠️
share/availability/full/availability.go 40.00% 2 Missing and 1 partial ⚠️
core/eds.go 60.00% 1 Missing and 1 partial ⚠️
header/headertest/fraud/testing.go 0.00% 1 Missing ⚠️
libs/edssser/edssser.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             shwap    #3751   +/-   ##
========================================
  Coverage         ?   46.74%           
========================================
  Files            ?      314           
  Lines            ?    17933           
  Branches         ?        0           
========================================
  Hits             ?     8383           
  Misses           ?     8535           
  Partials         ?     1015           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Wondertan Wondertan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One duplication nit, lgtm otherwise

store/store.go Show resolved Hide resolved
@Wondertan Wondertan merged commit 4289846 into celestiaorg:shwap Sep 20, 2024
22 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:feat Attached to feature PRs shwap
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants