Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nodebuilder/host): Ensure libp2p metrics are collected to prometheus #3753

Merged
merged 3 commits into from
Sep 23, 2024

Conversation

walldiss
Copy link
Member

@walldiss walldiss commented Sep 19, 2024

This PR fixes the bug of prometheus registry not being provided to libp2p constructor as well as few additional improvements of adjustment code:

  • provide Registrer to libp2p if flag is enabled
  • clarify telemetry enabling flag names and avoid overwrites

@walldiss walldiss added the kind:fix Attached to bug-fixing PRs label Sep 19, 2024
@walldiss walldiss self-assigned this Sep 19, 2024
@codecov-commenter
Copy link

codecov-commenter commented Sep 19, 2024

Codecov Report

Attention: Patch coverage is 27.77778% with 13 lines in your changes missing coverage. Please review.

Project coverage is 45.70%. Comparing base (2469e7a) to head (1718ae7).
Report is 200 commits behind head on main.

Files with missing lines Patch % Lines
cmd/flags_misc.go 0.00% 13 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3753      +/-   ##
==========================================
+ Coverage   44.83%   45.70%   +0.87%     
==========================================
  Files         265      281      +16     
  Lines       14620    16059    +1439     
==========================================
+ Hits         6555     7340     +785     
- Misses       7313     7880     +567     
- Partials      752      839      +87     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Wondertan
Wondertan previously approved these changes Sep 19, 2024
nodebuilder/p2p/metrics.go Outdated Show resolved Hide resolved
Wondertan
Wondertan previously approved these changes Sep 20, 2024
@Wondertan
Copy link
Member

@walldiss, did you test it yet to see if it works with Graphana?

vgonkivs
vgonkivs previously approved these changes Sep 23, 2024
@walldiss walldiss dismissed stale reviews from vgonkivs and Wondertan via 8aa929e September 23, 2024 11:47
@walldiss
Copy link
Member Author

This PR is tested and proven to be working. Fixes related to bitswap metrics initialisation extracted to separate PR:
#3763

Copy link
Member

@renaynay renaynay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utack

@renaynay renaynay enabled auto-merge (squash) September 23, 2024 12:18
@renaynay renaynay merged commit f875256 into celestiaorg:main Sep 23, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:fix Attached to bug-fixing PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants