-
Notifications
You must be signed in to change notification settings - Fork 925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(nodebuilder/host): Ensure libp2p metrics are collected to prometheus #3753
fix(nodebuilder/host): Ensure libp2p metrics are collected to prometheus #3753
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3753 +/- ##
==========================================
+ Coverage 44.83% 45.70% +0.87%
==========================================
Files 265 281 +16
Lines 14620 16059 +1439
==========================================
+ Hits 6555 7340 +785
- Misses 7313 7880 +567
- Partials 752 839 +87 ☔ View full report in Codecov by Sentry. |
@walldiss, did you test it yet to see if it works with Graphana? |
e756b0f
to
8aa929e
Compare
This PR is tested and proven to be working. Fixes related to bitswap metrics initialisation extracted to separate PR: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utack
This PR fixes the bug of prometheus registry not being provided to libp2p constructor as well as few additional improvements of adjustment code: