Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docker): set addr flags to 0.0.0.0 in entrypoint file #3808

Merged
merged 3 commits into from
Oct 4, 2024

Conversation

MSevey
Copy link
Member

@MSevey MSevey commented Oct 3, 2024

When using port forwarding in docker, you need to use the any address interface 0.0.0.0 otherwise you would be able to communicate to the server inside the container.

This PR updates the entrypoint.sh file to set the RPC and Gateway addresses to 0.0.0.0 so that developers can properly communicate to the node when exposing ports, for example -p 26658:26658.

@MSevey MSevey added the kind:fix Attached to bug-fixing PRs label Oct 3, 2024
@MSevey MSevey self-assigned this Oct 3, 2024
@github-actions github-actions bot added the external Issues created by non node team members label Oct 3, 2024
Copy link
Member

@Wondertan Wondertan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Copy link
Contributor

@sysrex sysrex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apart from length, is there any other reason to wrap it in COMMAND ?

@MSevey
Copy link
Member Author

MSevey commented Oct 3, 2024

apart from length, is there any other reason to wrap it in COMMAND ?

nope, just DRY'ing up the code a little.

@MSevey MSevey enabled auto-merge (squash) October 3, 2024 17:19
@MSevey
Copy link
Member Author

MSevey commented Oct 3, 2024

is this a known NDF in the test suite?
https://github.com/celestiaorg/celestia-node/actions/runs/11165146996/job/31036158882?pr=3808#step:4:402

--- FAIL: TestEDSStore (0.02s)
    --- FAIL: TestEDSStore/Second_Put_should_be_noop (0.00s)
        testing.go:1232: TempDir RemoveAll cleanup: unlinkat /tmp/TestEDSStoreSecond_Put_should_be_noop3464455727/001/blocks: directory not empty
FAIL

Copy link
Member

@renaynay renaynay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utack

@MSevey MSevey disabled auto-merge October 4, 2024 15:57
@MSevey MSevey enabled auto-merge (squash) October 4, 2024 15:57
@MSevey MSevey merged commit 896a46b into main Oct 4, 2024
29 checks passed
@MSevey MSevey deleted the entrypoint-command-update branch October 4, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external Issues created by non node team members kind:fix Attached to bug-fixing PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants