-
Notifications
You must be signed in to change notification settings - Fork 928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(docker): set addr flags to 0.0.0.0 in entrypoint file #3808
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
apart from length, is there any other reason to wrap it in COMMAND
?
nope, just DRY'ing up the code a little. |
is this a known NDF in the test suite?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utack
When using port forwarding in docker, you need to use the
any
address interface0.0.0.0
otherwise you would be able to communicate to the server inside the container.This PR updates the
entrypoint.sh
file to set the RPC and Gateway addresses to0.0.0.0
so that developers can properly communicate to the node when exposing ports, for example-p 26658:26658
.