fix(nodebuilder): flag parsing for --node.type needs lowercase string, list network aliases for --p2p.network #3827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… now, list all network aliases in description string of --p2p.network
renaynay
requested review from
Wondertan,
vgonkivs,
walldiss and
cristaloleg
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3827 +/- ##
==========================================
+ Coverage 44.83% 46.30% +1.47%
==========================================
Files 265 314 +49
Lines 14620 18140 +3520
==========================================
+ Hits 6555 8400 +1845
- Misses 7313 8717 +1404
- Partials 752 1023 +271 ☔ View full report in Codecov by Sentry. |
vgonkivs
approved these changes
Oct 8, 2024
walldiss
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3825 which was broken accidentally by #3759
Also lists all network aliases as well in
--p2p.networkdescription string.