Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(store): write actual share size to ods #3863

Merged
merged 3 commits into from
Oct 21, 2024

Conversation

walldiss
Copy link
Member

We used to write const for share size in file header. Instead we can write actual size from provided eds.

@walldiss walldiss added area:storage kind:refactor Attached to refactoring PRs labels Oct 18, 2024
@walldiss walldiss self-assigned this Oct 18, 2024
@codecov-commenter
Copy link

codecov-commenter commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.06%. Comparing base (2469e7a) to head (bc38562).
Report is 349 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3863      +/-   ##
==========================================
+ Coverage   44.83%   45.06%   +0.23%     
==========================================
  Files         265      314      +49     
  Lines       14620    21802    +7182     
==========================================
+ Hits         6555     9826    +3271     
- Misses       7313    10954    +3641     
- Partials      752     1022     +270     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@walldiss walldiss enabled auto-merge (squash) October 20, 2024 00:32
@walldiss walldiss merged commit 7d53e66 into celestiaorg:main Oct 21, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:storage kind:refactor Attached to refactoring PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants