!refactor(api/share): use height in share module #3870
Merged
+80
−122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walldiss
added
kind:break!
walldiss
requested review from
renaynay,
Wondertan,
vgonkivs and
cristaloleg
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3870 +/- ##
==========================================
+ Coverage 44.83% 45.16% +0.33%
==========================================
Files 265 311 +46
Lines 14620 21882 +7262
==========================================
+ Hits 6555 9884 +3329
- Misses 7313 10942 +3629
- Partials 752 1056 +304 ☔ View full report in Codecov by Sentry. |
Wondertan
reviewed
Oct 22, 2024
Wondertan
previously approved these changes
Oct 22, 2024
cristaloleg
previously approved these changes
Oct 22, 2024
|
conflicts ( |
walldiss
dismissed stale reviews from renaynay, cristaloleg, and Wondertan
via
793a91c
walldiss
force-pushed
the
update-share-api
branch
from
6fd0ba3
to
793a91c
Compare
walldiss
force-pushed
the
update-share-api
branch
from
793a91c
to
0a92fdf
Compare
cristaloleg
approved these changes
Oct 23, 2024
|
FYI @jcstein |
vgonkivs
approved these changes
Oct 23, 2024
renaynay
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use height instead of header in share module API