-
Notifications
You must be signed in to change notification settings - Fork 928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pruner/light): add light pruning for shwap #3896
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3896 +/- ##
==========================================
+ Coverage 44.83% 45.47% +0.64%
==========================================
Files 265 307 +42
Lines 14620 21825 +7205
==========================================
+ Hits 6555 9926 +3371
- Misses 7313 10835 +3522
- Partials 752 1064 +312 ☔ View full report in Codecov by Sentry. |
walldiss
force-pushed
the
add-light-pruning
branch
from
November 1, 2024 09:47
0a4388d
to
5706d30
Compare
walldiss
force-pushed
the
add-light-pruning
branch
from
November 1, 2024 12:30
5706d30
to
f18c5a3
Compare
walldiss
requested review from
renaynay,
Wondertan,
vgonkivs and
cristaloleg
as code owners
November 1, 2024 12:30
renaynay
reviewed
Nov 1, 2024
Wondertan
reviewed
Nov 1, 2024
renaynay
approved these changes
Nov 1, 2024
Wondertan
reviewed
Nov 1, 2024
Wondertan
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Light availability will now implement Pruner interface. It is logical step since Prune is the opposite of ShareAvailable. Mostly due to internal shared sync primitives, storage and private encoding structs. Refactoring of Pruner interface is not intended in this PR. It will be done in another PR where Pruner interface will be coupled with Availability interface.