Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(shwap/bitswap): tune bitswap params #3940

Merged
merged 6 commits into from
Nov 14, 2024
Merged

Conversation

Wondertan
Copy link
Member

@Wondertan Wondertan commented Nov 14, 2024

List of notable changes:

  • Fixes server-side peer serving prioritization by lowering message size.
    • Previously, some peer could max out server, while others rarely processed.
  • Fine-tuned don't have timeout configuration
  • Increasing number of workers

🎱 mb certified

@Wondertan Wondertan added the kind:fix Attached to bug-fixing PRs label Nov 14, 2024
@Wondertan Wondertan self-assigned this Nov 14, 2024
Copy link
Contributor

@cristaloleg cristaloleg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unapprove

@Wondertan Wondertan marked this pull request as ready for review November 14, 2024 11:46
share/shwap/p2p/bitswap/bitswap.go Outdated Show resolved Hide resolved
share/shwap/p2p/bitswap/bitswap.go Show resolved Hide resolved
Copy link
Member

@renaynay renaynay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utack 🤞🏻

share/shwap/p2p/bitswap/bitswap.go Show resolved Hide resolved
@Wondertan Wondertan enabled auto-merge (squash) November 14, 2024 16:30
@Wondertan Wondertan enabled auto-merge (squash) November 14, 2024 16:32
@Wondertan Wondertan merged commit 4bf1835 into main Nov 14, 2024
33 of 40 checks passed
@Wondertan Wondertan deleted the shwap-bitswap-params branch November 14, 2024 16:36
Wondertan added a commit that referenced this pull request Nov 15, 2024
List of notable changes:
* Fixes server-side peer serving prioritization by lowering message size.
   * Previously, some peer could max out server, while others rarely processed.
* Fine-tuned don't have timeout configuration
* Increasing number of workers

---

🎱 mb certified
Wondertan added a commit that referenced this pull request Nov 15, 2024
List of notable changes:
* Fixes server-side peer serving prioritization by lowering message size.
   * Previously, some peer could max out server, while others rarely processed.
* Fine-tuned don't have timeout configuration
* Increasing number of workers

---

🎱 mb certified
Wondertan added a commit that referenced this pull request Nov 15, 2024
List of notable changes:
* Fixes server-side peer serving prioritization by lowering message size.
   * Previously, some peer could max out server, while others rarely processed.
* Fine-tuned don't have timeout configuration
* Increasing number of workers

---

🎱 mb certified
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:fix Attached to bug-fixing PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants