fix(share/availability/light): Allow retries on ODS size 1 #3944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renaynay
added
area:shares
renaynay
requested review from
Wondertan,
vgonkivs,
walldiss and
cristaloleg
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3944 +/- ##
==========================================
+ Coverage 44.83% 45.51% +0.68%
==========================================
Files 265 308 +43
Lines 14620 21869 +7249
==========================================
+ Hits 6555 9954 +3399
- Misses 7313 10846 +3533
- Partials 752 1069 +317 ☔ View full report in Codecov by Sentry. |
walldiss
reviewed
Nov 18, 2024
walldiss
previously approved these changes
Nov 18, 2024
|
UT failed |
renaynay
force-pushed
the
sample-size
branch
from
80f6942
to
109a3c7
Compare
walldiss
approved these changes
Nov 18, 2024
Wondertan
approved these changes
Nov 18, 2024
Wondertan
pushed a commit
that referenced
this pull request
Nov 18, 2024
Fixes #3943 Another PR will come later which optimises the request for the single-share-square case :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3943
Another PR will come later which optimises the request for the single-share-square case :)