-
Notifications
You must be signed in to change notification settings - Fork 961
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(share): add Full Node reconstruction tests #702
Conversation
Did you link to the right issue? #598 is a closed PR. |
Draft until #682 is merged |
88119a0
to
2d9bd5c
Compare
79635d2
to
d5c0dd4
Compare
d5c0dd4
to
a07a81f
Compare
a07a81f
to
20c0936
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #702 +/- ##
==========================================
+ Coverage 53.93% 54.19% +0.25%
==========================================
Files 121 121
Lines 6968 7016 +48
==========================================
+ Hits 3758 3802 +44
- Misses 2823 2830 +7
+ Partials 387 384 -3 ☔ View full report in Codecov by Sentry. |
So the main blocker here is to make tests run while being limited with 8k goroutines, which is not trivial. |
No plan yet. I would like to have them merged so hard, so I will probably disable the race flag for them somehow |
Also, it would be good to extend these tests with discovery |
d3a150d
to
5182a17
Compare
I extracted the tests and disabled the race detector for them. Fully ready for review |
4bc7fa4
to
88e5015
Compare
@musalbas, added you here as a reviewer. Do we need more harness tests or is this enough? Do we need tests where there are more than two Fulls with their own subnetworks? |
In general we need to test multiple full nodes, but I'm not sure if that's something we need as a harness test, but rather a network test using e.g. testground. |
Ok, then I think there is nothing else to do in this PR. Testground reconstruction test is planned but orthogonal to this PR. |
…l and Light concepts and introduce subnets
…reconstruct data from light nodes only
…s after the test are passed
… disabled race detector
88e5015
to
982b22d
Compare
Co-authored-by: John Adler <adlerjohn@users.noreply.github.com>
Mainly:
For an in-depth description of each test consult a complementary comment to each test.
Substitutes #598
Based on #682
Closes #600
My favourite part about these tests is that they won't require any changes if we e.g., move to a completely new protocol for Share transportation