Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

service/state: Only request balance if node is synced #933

Closed
wants to merge 6 commits into from

Conversation

renaynay
Copy link
Member

@renaynay renaynay commented Jul 22, 2022

Since balance retrieval will now rely on the node's chain rather than just proxying the request through to the core node, /balance requests will only return successfully if the node is synced to network head.

Based on #911.

TODO:

@renaynay renaynay added area:state Related to fetching state and state execution kind:improvement labels Jul 22, 2022
@renaynay renaynay self-assigned this Jul 22, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #933 (7d6cea2) into main (718f364) will increase coverage by 0.15%.
The diff coverage is 27.27%.

@@            Coverage Diff             @@
##             main     #933      +/-   ##
==========================================
+ Coverage   58.26%   58.41%   +0.15%     
==========================================
  Files         129      129              
  Lines        7727     7736       +9     
==========================================
+ Hits         4502     4519      +17     
+ Misses       2754     2745       -9     
- Partials      471      472       +1     
Impacted Files Coverage Δ
header/sync/sync.go 64.85% <0.00%> (-0.65%) ⬇️
service/state/service.go 40.00% <25.00%> (-7.83%) ⬇️
node/state/state.go 100.00% <100.00%> (ø)
fraud/pb/proof.pb.go 33.51% <0.00%> (+4.28%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us.

@renaynay renaynay closed this Sep 14, 2022
@renaynay renaynay deleted the provide-bal-if-synced branch September 14, 2022 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:state Related to fetching state and state execution
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants