feat: merge the QGB v0.46.x branch to the default one #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* adds orchestrator address to validator initialization in staking module * fix msg edit validator * todo * todo
…r struct (#133) * first pass on tests fixes * fixes the rest of unit tests * remove unnecessary comments * uses default eth address when starting sim network * cosmetics * comments failing test * comments failing test * uncomments test and fixes it from commit 434b308 * remove wrong testnet initialization
* first pass on tests fixes * fixes the rest of unit tests * remove unnecessary comments * uses default eth address when starting sim network * cosmetics * comments failing test * comments failing test * adds orchestrator/ethereum address checks for validators when creating and editing * uses correct error codes for eth/orch address errors * uncomments test and fixes it from commit 434b308 * adds zero eth address check when creating/updating validator * attempts to fix duplicate eth address in sim network * revert squashed changes * uses unwrapped context for msg_server orch/eth validation * increase DefaultGenTxGas to accomodate new qgb validator changes * scaffolds an ethereum address from orchestrator address in staking simulation to have a deterministic way of creating it * fix eth address creation from orch address in operations * increase DefaultGenTxGas * increase DefaultGenTxGas * simpler way of creating an eth address from orch address in operations
* first pass on tests fixes * fixes the rest of unit tests * remove unnecessary comments * uses default eth address when starting sim network * cosmetics * comments failing test * comments failing test * adds orchestrator/ethereum address checks for validators when creating and editing * uses correct error codes for eth/orch address errors * uncomments test and fixes it from commit 434b308 * updates tests to be able to set orch/eth address when creating validators * adds zero eth address check when creating/updating validator * attempts to fix duplicate eth address in sim network * adds validator check tests * revert squashed changes * uses unwrapped context for msg_server orch/eth validation * increase DefaultGenTxGas to accomodate new qgb validator changes * scaffolds an ethereum address from orchestrator address in staking simulation to have a deterministic way of creating it * fix eth address creation from orch address in operations * increase DefaultGenTxGas * increase DefaultGenTxGas * remove unnecessary eth address
* remove EthAddress and use geth address * adding checks on ethereum address when creating it * fix ethereum address init when creating validator * fix edit validator
go mod tidy go mod tidy remove unnecessary change remove unnecessary else branch fix gentx test update staking.pb.go fix staking cli tests fixing tests: first pass proto-gen
…ial-probably chore!: Upgrade QGB branch to v0.46.0
rach-id
added
enhancement
evan-forbes
reviewed
Sep 16, 2022
Comment on lines
+127
to
+132
| // The orchestrator field is a celes1... string (i.e. sdk.AccAddress) that | ||
| // references the key that is being delegated to | ||
| string orchestrator = 12; | ||
| // This is a hex encoded 0x Ethereum public key that will be used by this | ||
| // validator on Ethereum | ||
| string eth_address = 13; |
There was a problem hiding this comment.
it's not possible to start a chain without these, correct?
if so, we'll need to collect this info from validators before the upgrade and include it in the genesis celestiaorg/celestia-app#608
|
@evan-forbes The linter is out of hand. It is failing because of a missing package: Probably because we're using But that can be handled in a separate PR. Let me know if you agree to create an issue. PS: I did update it locally, but all the proto generated files were changed. So, it's out of scope of this PR. For the other failing CI, it's the traditional breaking changes. Let me know if this is alright, so we merge. |
|
Yeah, let's create an issue and update the proto generation. Then we can merge that here, and merge this |
# Conflicts: # x/staking/types/staking.pb.go
feat: Merge 0.46.x-celestia on QGB feature branch
|
@evan-forbes we clicked on the same time 😃 |
|
💪 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge the QGB feature branch to the default branch in preparation for the QGB app merge.