-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Revert "fix: update buf to v1.7.0 and regenerate proto files (#280)" #343
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -12,7 +12,7 @@ SIMAPP = ./simapp | |
MOCKS_DIR = $(CURDIR)/tests/mocks | ||
HTTPS_GIT := https://github.com/cosmos/cosmos-sdk.git | ||
DOCKER := $(shell which docker) | ||
DOCKER_BUF := $(DOCKER) run --rm -v $(CURDIR):/workspace --workdir /workspace bufbuild/buf:1.7.0 | ||
DOCKER_BUF := $(DOCKER) run --rm -v $(CURDIR):/workspace --workdir /workspace bufbuild/buf:1.0.0-rc8 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
PROJECT_NAME = $(shell git remote get-url origin | xargs basename -s .git) | ||
DOCS_DOMAIN=docs.cosmos.network | ||
|
||
|
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,16 +4,20 @@ deps: | |
- remote: buf.build | ||
owner: cosmos | ||
repository: cosmos-proto | ||
branch: main | ||
commit: 1935555c206d4afb9e94615dfd0fad31 | ||
- remote: buf.build | ||
owner: cosmos | ||
repository: cosmos-sdk | ||
commit: 44369accb517453db1f2228530da42c0 | ||
branch: main | ||
commit: 86d2a697b026488089f13a71ceb3815c | ||
Comment on lines
9
to
+13
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [note] the commit looks different from upstream https://github.com/cosmos/cosmos-sdk/blob/2a48f6d7a24b728ac64eafe0929bb8893cc23ccf/client/v2/internal/buf.lock#L8-L11 although I'm not if it is necessary for these to match exactly |
||
- remote: buf.build | ||
owner: cosmos | ||
repository: gogo-proto | ||
commit: 6652e3443c3b4504bb3bf82e73a7e409 | ||
branch: main | ||
commit: bee5511075b7499da6178d9e4aaa628b | ||
- remote: buf.build | ||
owner: googleapis | ||
repository: googleapis | ||
commit: 62f35d8aed1149c291d606d958a7ce32 | ||
branch: main | ||
commit: 40f07f5b563941f2b20b991a7aedd53d | ||
Comment on lines
19
to
+23
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [note] the commit looks different from upstream: https://github.com/cosmos/cosmos-sdk/blob/2a48f6d7a24b728ac64eafe0929bb8893cc23ccf/client/v2/internal/buf.lock#L16-L19 although I'm not if it is necessary for these to match exactly |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,7 +2,7 @@ | |
# docker build --pull --rm -f "contrib/devtools/Dockerfile" -t cosmossdk-proto:latest "contrib/devtools" | ||
# docker run --rm -v $(pwd):/workspace --workdir /workspace cosmossdk-proto sh ./scripts/protocgen.sh | ||
|
||
FROM bufbuild/buf:1.7.0 as BUILDER | ||
FROM bufbuild/buf:1.1.0 as BUILDER | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
|
||
FROM golang:1.19-alpine | ||
|
||
|
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -17,7 +17,6 @@ require ( | |
github.com/cosmos/cosmos-proto v1.0.0-alpha7 | ||
github.com/cosmos/cosmos-sdk/db v1.0.0-beta.1 | ||
github.com/cosmos/go-bip39 v1.0.0 | ||
github.com/cosmos/gogoproto v1.4.10 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👍 upstream doesn't depend on cosmos/gogoproto |
||
github.com/cosmos/iavl v0.19.6 | ||
github.com/cosmos/ledger-cosmos-go v0.12.2 | ||
github.com/gogo/gateway v1.1.0 | ||
|
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 https://github.com/cosmos/cosmos-sdk/blob/2a48f6d7a24b728ac64eafe0929bb8893cc23ccf/.github/workflows/proto.yml#L20