Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TrustedPoint archive node domain (RPC, gRPC, API) on mocha & mainnet.md #1412

Merged
merged 2 commits into from
Feb 12, 2024

Conversation

Hacker-web-Vi
Copy link
Contributor

@Hacker-web-Vi Hacker-web-Vi commented Feb 10, 2024

Hello!
We made a rebranding some time ago and migrating to a different domain names. So we would like to update our services on mocha.

Summary by CodeRabbit

  • Documentation
    • Updated RPC and API endpoints for the Celestia network in the documentation.
    • Added a new RPC endpoint and corresponding API and gRPC endpoints for Mainnet Beta participation.

Copy link
Contributor

coderabbitai bot commented Feb 10, 2024

Walkthrough

The Celestia network's mocha testnet and mainnet have undergone endpoint updates, aligning RPC, API, and gRPC services with the new domain trusted-point.com. These changes ensure seamless connectivity to the network resources with the latest configurations.

Changes

File Path Change Summary
nodes/mocha-testnet.md Updated RPC, API, and gRPC endpoints from *.testnet-pride.com to *.trusted-point.com
nodes/mainnet.md Added a new RPC endpoint rpc-celestia-mainnet.trusted-point.com for Mainnet Beta participation

🏈🐇 A whimsical verse from the burrow, as the big game unfurls,
In fields of green, under the bright lights, two teams swirl.
Chiefs in the hunt, 49ers with might, a spirited clash begins,
Through passes and runs, a battle of wins,
Yet in this game, where rivals vie,
We cheer and leap, under February's sky.
So here's to changes, both on field and net,
A dance of digits and athletes, on this Super Bowl bet. 🏆🎉

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 1dfa37f and 1c0a509.
Files selected for processing (1)
  • nodes/mocha-testnet.md (3 hunks)
Additional comments: 3
nodes/mocha-testnet.md (3)
  • 83-83: Ensure the new RPC endpoint rpc-celestia-mocha.trusted-point.com correctly replaces the old rpc-celestia-mocha.testnet-pride.com domain as intended. Confirm the domain is accessible and resolves correctly.
  • 102-102: Verify that the new API endpoint https://api-celestia-mocha.trusted-point.com accurately replaces https://api-celestia-mocha.testnet-pride.com, ensuring the URL is correctly formatted and the domain is operational.
  • 122-122: Confirm the new gRPC endpoint grpc-celestia-mocha.trusted-point.com:9099 is a correct replacement for grpc-celestia-mocha.testnet-pride.com:9099. Check for correct port usage and domain resolution.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 1c0a509 and a2a4244.
Files selected for processing (1)
  • nodes/mainnet.md (3 hunks)
Additional comments: 3
nodes/mainnet.md (3)
  • 115-115: The addition of rpc-celestia-mainnet.trusted-point.com seems unrelated to the PR's stated objectives of updating domain names for the Mocha testnet. Please clarify if this change is intended for this PR.
  • 135-135: The addition of api-celestia-mainnet.trusted-point.com appears to be unrelated to the PR's objectives concerning the Mocha testnet. Confirm if this inclusion is correct for the current PR.
  • 154-154: Adding grpc-celestia-mainnet.trusted-point.com:9095 does not align with the PR's focus on the Mocha testnet domain name updates. Ensure this change is supposed to be part of this PR.

@Hacker-web-Vi Hacker-web-Vi changed the title Update TrustedPoint domain of the archive node (RPC, gRPC, API) to mocha-testnet.md Update TrustedPoint archive node domain (RPC, gRPC, API) on mocha & mainnet.md Feb 10, 2024
@@ -80,7 +80,7 @@ Celestia network. The default port is 26657.
- `celestia-rpc.f5nodes.com`
- `celestia-testnet.brightlystake.com`
- `rpc-celestia-mocha.architectnodes.com`
- `rpc-celestia-mocha.testnet-pride.com`
- `rpc-celestia-mocha.trusted-point.com`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you confirm you're replacing one of your own endpoints? @Hacker-web-Vi

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you confirm you're replacing one of your own endpoints? @Hacker-web-Vi

@jcstein confirming

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty. :shipit:

@jcstein jcstein merged commit 7e15b06 into celestiaorg:main Feb 12, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants