-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update TrustedPoint archive node domain (RPC, gRPC, API) on mocha & mainnet.md #1412
Conversation
WalkthroughThe Celestia network's mocha testnet and mainnet have undergone endpoint updates, aligning RPC, API, and gRPC services with the new domain Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- nodes/mocha-testnet.md (3 hunks)
Additional comments: 3
nodes/mocha-testnet.md (3)
- 83-83: Ensure the new RPC endpoint
rpc-celestia-mocha.trusted-point.com
correctly replaces the oldrpc-celestia-mocha.testnet-pride.com
domain as intended. Confirm the domain is accessible and resolves correctly.- 102-102: Verify that the new API endpoint
https://api-celestia-mocha.trusted-point.com
accurately replaceshttps://api-celestia-mocha.testnet-pride.com
, ensuring the URL is correctly formatted and the domain is operational.- 122-122: Confirm the new gRPC endpoint
grpc-celestia-mocha.trusted-point.com:9099
is a correct replacement forgrpc-celestia-mocha.testnet-pride.com:9099
. Check for correct port usage and domain resolution.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- nodes/mainnet.md (3 hunks)
Additional comments: 3
nodes/mainnet.md (3)
- 115-115: The addition of
rpc-celestia-mainnet.trusted-point.com
seems unrelated to the PR's stated objectives of updating domain names for the Mocha testnet. Please clarify if this change is intended for this PR.- 135-135: The addition of
api-celestia-mainnet.trusted-point.com
appears to be unrelated to the PR's objectives concerning the Mocha testnet. Confirm if this inclusion is correct for the current PR.- 154-154: Adding
grpc-celestia-mainnet.trusted-point.com:9095
does not align with the PR's focus on the Mocha testnet domain name updates. Ensure this change is supposed to be part of this PR.
@@ -80,7 +80,7 @@ Celestia network. The default port is 26657. | |||
- `celestia-rpc.f5nodes.com` | |||
- `celestia-testnet.brightlystake.com` | |||
- `rpc-celestia-mocha.architectnodes.com` | |||
- `rpc-celestia-mocha.testnet-pride.com` | |||
- `rpc-celestia-mocha.trusted-point.com` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you confirm you're replacing one of your own endpoints? @Hacker-web-Vi
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you confirm you're replacing one of your own endpoints? @Hacker-web-Vi
@jcstein confirming
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ty.
Hello!
We made a rebranding some time ago and migrating to a different domain names. So we would like to update our services on mocha.
Summary by CodeRabbit