This repository has been archived by the owner on Apr 30, 2024. It is now read-only.
Add changes to use Optimint v0.1.1 #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbowen93
changed the title
adlerjohn
reviewed
Mar 8, 2022
Not trivially. Some of the tests assume you can start a chain w/ just the Also the solidity tests are a bit of a mess. I'm almost done manually testing things and then I'll post some verification that things pass locally on the ephemeral cluster. |
|
There are some legitimately not working RPC Tests: #7 and the solidity tests should probably be redone. |
Codecov Report
@@ Coverage Diff @@
## main #4 +/- ##
==========================================
+ Coverage 59.43% 59.46% +0.02%
==========================================
Files 78 78
Lines 6452 6449 -3
==========================================
Hits 3835 3835
+ Misses 2401 2398 -3
Partials 216 216
|
|
I'd like to merge this while acknowledging the known failures and not cutting a v0.1.0 release yet. |
tzdybal
approved these changes
Mar 14, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds changes from the tzdybal/optimint branch while already being rebased on the github.com/tharsis/ethermint main branch.
It should be squashed before merging.
This has been manually tested to work with Cevmos.
After merging a follow up commit to update the Changelog should be made and a v0.1.0 release should be cut.
#3