fix!: handle error on metrics #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wondertan
requested review from
tzdybal,
renaynay,
vgonkivs and
gupadhyaya
as code owners
Wondertan
force-pushed
the
p2p/susbcriber/error
branch
from
83a08c9 to
4716bc9
Compare
Codecov Report
@@ Coverage Diff @@
## main #123 +/- ##
==========================================
- Coverage 69.43% 69.27% -0.17%
==========================================
Files 37 37
Lines 2971 2981 +10
==========================================
+ Hits 2063 2065 +2
- Misses 761 769 +8
Partials 147 147
|
renaynay
approved these changes
Oct 12, 2023
vgonkivs
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I treated metrics initialization as like it's being run in
initwhile it's not. Even if these are programmer bug errors, metrics initialization will happen after some other components have started, causing various artifacts if not stopped gracefully.