Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(store): add Tail method #210

Merged
merged 2 commits into from
Oct 4, 2024
Merged

feat(store): add Tail method #210

merged 2 commits into from
Oct 4, 2024

Conversation

cristaloleg
Copy link
Contributor

Overview

Add .Tail method to header.Store[H] and store.Store[H] implementation. For now method tries to return genesis header. In the future PRs method will start returning real tail of the store.

Updates #203

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 26.31579% with 14 lines in your changes missing coverage. Please review.

Please upload report for BASE (backward-sync@7d9aad6). Learn more about missing BASE report.

Files Patch % Lines
headertest/store.go 0.00% 8 Missing ⚠️
store/store.go 45.45% 6 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##             backward-sync     #210   +/-   ##
================================================
  Coverage                 ?   63.32%           
================================================
  Files                    ?       38           
  Lines                    ?     3610           
  Branches                 ?        0           
================================================
  Hits                     ?     2286           
  Misses                   ?     1155           
  Partials                 ?      169           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cristaloleg cristaloleg marked this pull request as ready for review July 1, 2024 13:33
cristaloleg added a commit that referenced this pull request Aug 13, 2024
## Overview

Adding method that will return tail header from the underlying datastore
when `Store[H]` will be started. Similar to `readHead` method in
`Store[H]`.

Should be merged after #210
@cristaloleg cristaloleg merged commit ebe21fe into backward-sync Oct 4, 2024
2 checks passed
@cristaloleg cristaloleg deleted the add-tail-method branch October 4, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants