fix(sync): Allow some more slack for recency estimation #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renaynay
requested review from
tzdybal,
Wondertan,
vgonkivs and
gupadhyaya
as code owners
|
Had an idea related to this #98 |
Wondertan
reviewed
Aug 23, 2023
Codecov Report
@@ Coverage Diff @@
## main #97 +/- ##
==========================================
+ Coverage 68.48% 68.91% +0.42%
==========================================
Files 37 37
Lines 2929 2937 +8
==========================================
+ Hits 2006 2024 +18
+ Misses 772 764 -8
+ Partials 151 149 -2
|
Wondertan
requested changes
Aug 24, 2023
Wondertan
reviewed
Aug 25, 2023
vgonkivs
approved these changes
Aug 25, 2023
Wondertan
approved these changes
Aug 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doubles the blocktime + some drift to allow a bit more slack for recency determination. The aim here is to increase the threshold for requesting head over Exchange if it isn't completely necessary.
resolves #98