Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Kaniko builder resource limit #334

Merged
merged 1 commit into from
May 14, 2024

Conversation

mojtaba-esk
Copy link
Member

@mojtaba-esk mojtaba-esk commented May 13, 2024

An issue reported by @rach-id on kaniko build. After investigation, it turned out that it hit the ephemeral storage limit and it seems to be working with 10Gi when building Celestia-app repo.

This PR suggests a fix to resolve that issue.
More context can be found in this chat.

Note: I could not run it on the current version of Robusta as the pod keeps pending for ever to get the resources; tested it on local minikube.

@mojtaba-esk mojtaba-esk requested a review from a team May 13, 2024 16:40
@mojtaba-esk mojtaba-esk self-assigned this May 13, 2024
@mojtaba-esk
Copy link
Member Author

Merging this PR must wait until we fix the resource provision for it and then it passes the TestBuildFromGit test.

Copy link
Member

@rach-id rach-id left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally, we should have a mechanism that deletes old images if the storage is full. Or even delete all the images. I think all the images would be good for nothing once the tests are over

@smuu
Copy link
Member

smuu commented May 14, 2024

Ideally, we should have a mechanism that deletes old images if the storage is full. Or even delete all the images. I think all the images would be good for nothing once the tests are over

This is not about images that are not used anymore. We use ephemeral storage, which only exists while the Pod runs. As Kaniko uses more than we thought, our Kubernetes nodes were unprepared for that. We increased that limit, which should fix it.

By the way, Kubernetes has a garbage collector that deletes unused images if the disk runs full.

@mojtaba-esk mojtaba-esk merged commit 4358db5 into main May 14, 2024
3 of 4 checks passed
@mojtaba-esk mojtaba-esk deleted the mojtaba/fix-kaniko-builder-resource-limit branch May 14, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants