bugfix: sidecar should use parents service #346

smuu · 2024-05-17T07:47:29Z

Overview

Signed-off-by: Smuu <18609909+Smuu@users.noreply.github.com>

mojtaba-esk

Well done 🚀

pkg/knuu/instance.go

pkg/knuu/instance_helper.go

Signed-off-by: Smuu <18609909+Smuu@users.noreply.github.com>

pkg/builder/builder.go

bugfix: sidecar should use parents service

1662589

Signed-off-by: Smuu <18609909+Smuu@users.noreply.github.com>

smuu requested a review from mojtaba-esk May 17, 2024 07:47

smuu added the knuu label May 17, 2024

mojtaba-esk previously approved these changes May 17, 2024

View reviewed changes

pkg/knuu/instance.go Show resolved Hide resolved

pkg/knuu/instance_helper.go Outdated Show resolved Hide resolved

bugfix: assign one var to another

cd88e2e

Signed-off-by: Smuu <18609909+Smuu@users.noreply.github.com>

smuu dismissed mojtaba-esk’s stale review via cd88e2e May 17, 2024 09:00

smuu enabled auto-merge May 17, 2024 09:00

mojtaba-esk approved these changes May 17, 2024

View reviewed changes

pkg/builder/builder.go Show resolved Hide resolved

Merge branch 'main' into smuu/fix-service-when-ports-on-sidecar

d46ded5

smuu disabled auto-merge May 17, 2024 09:43

smuu merged commit f06c706 into main May 17, 2024
2 of 3 checks passed

smuu deleted the smuu/fix-service-when-ports-on-sidecar branch May 17, 2024 09:43