Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds the Size() method to the nmt API #191

Merged
merged 2 commits into from
May 4, 2023
Merged

Conversation

staheri14
Copy link
Contributor

@staheri14 staheri14 commented May 4, 2023

Overview

Closes #160

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@staheri14 staheri14 requested review from evan-forbes and liamsi May 4, 2023 18:02
@staheri14 staheri14 self-assigned this May 4, 2023
@staheri14 staheri14 added the API label May 4, 2023
@staheri14 staheri14 marked this pull request as ready for review May 4, 2023 18:03
@codecov
Copy link

codecov bot commented May 4, 2023

Codecov Report

❗ No coverage uploaded for pull request base (master@d0789c6). Click here to learn what that means.
The diff coverage is 100.00%.

❗ Current head ab2d666 differs from pull request most recent head b78ba42. Consider uploading reports for the commit b78ba42 to get more accurate results

@@            Coverage Diff            @@
##             master     #191   +/-   ##
=========================================
  Coverage          ?   95.71%           
=========================================
  Files             ?        5           
  Lines             ?      560           
  Branches          ?        0           
=========================================
  Hits              ?      536           
  Misses            ?       14           
  Partials          ?       10           
Impacted Files Coverage Δ
nmt.go 98.02% <100.00%> (ø)

@staheri14 staheri14 merged commit f6e7254 into master May 4, 2023
@staheri14 staheri14 deleted the adds-size-method branch May 4, 2023 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create accessory method for consistent tree size retrieval
3 participants