Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments about extending data are wrong #192

Closed
andrijamitrovic23 opened this issue Jun 22, 2023 · 0 comments · Fixed by #193
Closed

Comments about extending data are wrong #192

andrijamitrovic23 opened this issue Jun 22, 2023 · 0 comments · Fixed by #193
Assignees

Comments

@andrijamitrovic23
Copy link

In erasureExtendSquare function first does extending and filling with arrays of nulls as data chunks of the original data square, then does the filling in the extended parts with encoded original data. However even if the original square data is extended previously the comments (first, second, third, fourth and fifth) are suggesting that extending is done after them where only filling in the extended shares with the encoded data.

Use something like “filling in the data” instead “extending data" within the mentioned comments to avoid confusion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants