Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: improve comments about extending #193

Merged
merged 2 commits into from
Jun 23, 2023

Conversation

rootulp
Copy link
Collaborator

@rootulp rootulp commented Jun 22, 2023

Closes #192

@rootulp rootulp self-assigned this Jun 22, 2023
@rootulp rootulp marked this pull request as ready for review June 22, 2023 17:44
@codecov
Copy link

codecov bot commented Jun 22, 2023

Codecov Report

Merging #193 (b18292e) into master (328fe4d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #193   +/-   ##
=======================================
  Coverage   81.22%   81.22%           
=======================================
  Files           7        7           
  Lines         522      522           
=======================================
  Hits          424      424           
  Misses         58       58           
  Partials       40       40           
Impacted Files Coverage Δ
datasquare.go 93.71% <ø> (ø)
extendeddatasquare.go 75.00% <ø> (ø)

@rootulp rootulp requested a review from staheri14 June 22, 2023 18:15
Copy link
Contributor

@staheri14 staheri14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@rootulp rootulp merged commit af44d93 into celestiaorg:master Jun 23, 2023
@rootulp rootulp deleted the rp/comments-about-extending branch June 23, 2023 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Comments about extending data are wrong
3 participants