Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

api: add helper methods to EDS struct #234

Closed
Wondertan opened this issue Jul 6, 2023 · 1 comment · Fixed by #241
Closed

api: add helper methods to EDS struct #234

Wondertan opened this issue Jul 6, 2023 · 1 comment · Fixed by #241
Assignees
@rootulp
Labels
enhancement New feature or request

Comments

@Wondertan
Copy link
Member

Wondertan commented Jul 6, 2023 •
edited
Loading

In node, we defined these helpers, which are better be methods on EDS instead:

  • Equal
  • ExtractEDS
  • ExtractODS
@rootulp rootulp mentioned this issue Jul 6, 2023
Closed
@rootulp rootulp added the enhancement New feature or request label Jul 6, 2023
@Wondertan
Copy link
Member Author

@rootulp, ExtractEDS is the same as Flatten, which seems to be fairly new method.

Also, note that we are good we any naming you think is the best.

@rootulp rootulp self-assigned this Jul 7, 2023
@rootulp rootulp mentioned this issue Jul 7, 2023
Merged
rootulp added a commit that referenced this issue Jul 13, 2023
@rootulp
feat(eds): FlattenedEDS, FlattenedODS, Equals (#241)
a8bd04b 
Closes #234

cc: @Wondertan
0xchainlover pushed a commit to celestia-org/rsmt2d that referenced this issue Aug 1, 2024
@rootulp
feat(eds): FlattenedEDS, FlattenedODS, Equals (#241)
3039a8a 
Closes celestiaorg/rsmt2d#234

cc: @Wondertan
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rootulp rootulp

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(eds): Flattened, FlattenedODS, Equals rootulp/rsmt2d
2 participants
@rootulp @Wondertan