Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove test cases that vary based on codec #274

Merged

Conversation

sontrinh16
Copy link
Contributor

@sontrinh16 sontrinh16 commented Dec 10, 2023

Overview

Closed: #216

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@rootulp rootulp changed the title [Refactor] Remove test cases that vary based on codec for extendeddatacrossword_test.go test: remove test cases that vary based on codec Dec 11, 2023
extendeddatacrossword_test.go Outdated Show resolved Hide resolved
extendeddatacrossword_test.go Outdated Show resolved Hide resolved
extendeddatacrossword_test.go Outdated Show resolved Hide resolved
rootulp
rootulp previously approved these changes Dec 11, 2023
Copy link
Collaborator

@rootulp rootulp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

extendeddatacrossword_test.go Outdated Show resolved Hide resolved
extendeddatacrossword_test.go Outdated Show resolved Hide resolved
@sontrinh16
Copy link
Contributor Author

seems like we need another approving review to merge this

@rootulp rootulp merged commit 14d878d into celestiaorg:main Dec 12, 2023
3 checks passed
Copy link

gitpoap-bot bot commented Dec 12, 2023

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2023 Celestia Contributor:

GitPOAP: 2023 Celestia Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove test cases that vary based on codec for extendeddatacrossword_test.go
3 participants