feat!: delete getTreeNameFromConstructorFn
#287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rootulp
changed the title
ComputeExtendedDataSquare to use treeName parametergetTreeNameFromConstructorFn
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #287 +/- ##
==========================================
+ Coverage 80.89% 81.42% +0.52%
==========================================
Files 8 8
Lines 869 845 -24
==========================================
- Hits 703 688 -15
+ Misses 119 113 -6
+ Partials 47 44 -3 ☔ View full report in Codecov by Sentry. |
staheri14
previously approved these changes
Jan 30, 2024
5 tasks
evan-forbes
previously approved these changes
Jan 31, 2024
Wondertan
approved these changes
Jan 31, 2024
|
Ready for re-review. I would like to hold off on merging until after I verify that celestia-app is able to use this. |
evan-forbes
approved these changes
Feb 1, 2024
Wondertan
approved these changes
Feb 2, 2024
This was referenced Feb 3, 2024
rootulp
added a commit
to rootulp/rsmt2d
that referenced
this pull request
Feb 3, 2024
This reverts commit 5a03c15.
rootulp
added a commit
that referenced
this pull request
Feb 7, 2024
While attempting to bump celestia-app to the v0.12.0-rc2, I noticed that the `RegisterTree` design leaks an implementation detail to celestia-app: the registering and managing of `treeName`s. Celestia-app has two categories of of trees: 1. erasured namespaced merkle tree in [nmt_wrapper.go](https://github.com/celestiaorg/celestia-app/blob/main/pkg/wrapper/nmt_wrapper.go) 2. EDS subtree root cacher [nmt_caching.go](https://github.com/celestiaorg/celestia-app/blob/main/pkg/inclusion/nmt_caching.go) Each of those categories has trees based on square size and NMT options. Celestia-app needs to be careful to register all the appropriate trees once (and only once) before they are used (via `Compute` or `Import`). I'd like to explore a less breaking option to get celestia-node the original desired feature which was #275. In the meantime, I think we should revert the two big breaking changes so that main can remain release-able. Revert #277 Revert #287 Closes #295 because no longer relevant if we merge this.
0xchainlover
pushed a commit
to celestia-org/rsmt2d
that referenced
this pull request
Aug 1, 2024
While attempting to bump celestia-app to the v0.12.0-rc2, I noticed that the `RegisterTree` design leaks an implementation detail to celestia-app: the registering and managing of `treeName`s. Celestia-app has two categories of of trees: 1. erasured namespaced merkle tree in [nmt_wrapper.go](https://github.com/celestiaorg/celestia-app/blob/main/pkg/wrapper/nmt_wrapper.go) 2. EDS subtree root cacher [nmt_caching.go](https://github.com/celestiaorg/celestia-app/blob/main/pkg/inclusion/nmt_caching.go) Each of those categories has trees based on square size and NMT options. Celestia-app needs to be careful to register all the appropriate trees once (and only once) before they are used (via `Compute` or `Import`). I'd like to explore a less breaking option to get celestia-node the original desired feature which was celestiaorg/rsmt2d#275. In the meantime, I think we should revert the two big breaking changes so that main can remain release-able. Revert celestiaorg/rsmt2d#277 Revert celestiaorg/rsmt2d#287 Closes celestiaorg/rsmt2d#295 because no longer relevant if we merge this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #286 by deleting
getTreeNameFromConstructorFn.Closes #288, #289 by fixing those tests.
Inspired by #278
Includes two breaking changes:
ComputeExtendedDataSquarenow accepts a parametertreeName: stringImportExtendedDataSquarenow accepts a parametertreeName: string