This repository has been archived by the owner on Feb 27, 2023. It is now read-only.
Minor improvements #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove obsolete key param in updateWithSideNodes - remove redundant parentheses - properly format example code and make explicit that Update returns to params
|
Visit https://dashboard.github.orijtech.com?back=0&pr=60&remote=false&repo=celestiaorg%2Fsmt to see benchmark details. |
Codecov Report
@@ Coverage Diff @@
## master #60 +/- ##
=======================================
Coverage 85.62% 85.62%
=======================================
Files 6 6
Lines 466 466
=======================================
Hits 399 399
Misses 39 39
Partials 28 28
Continue to review full report at Codecov.
|
musalbas
approved these changes
Sep 17, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updateWithSideNodesintroduced in Implement removal of orphan nodes #37 and only removed on deletes a207801As a nice side effect this will trigger having a baseline on master for future benchmark runs of bencher.