Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move examples to cellarium.ml.cli #89

Merged
merged 14 commits into from
Oct 12, 2023
Merged

Move examples to cellarium.ml.cli #89

merged 14 commits into from
Oct 12, 2023

Conversation

ordabayevy
Copy link
Contributor

@ordabayevy ordabayevy commented Oct 10, 2023 •
edited
Loading

  • Move examples to cellarium.ml.cli. This allows importing main functions and calling them. e.g. by the Vertex AI components to form pipelines
  • Introduce lightning_cli_factory function to create new classes of LightningCLI on demand. This allows setting the default model and linking arguments
  • Add cellarium-ml script in pyproject.toml to allow training models from the shell. Usage example: cellarium-ml incremental_pca fit --config config.yaml

@ordabayevy ordabayevy requested a review from mbabadi October 10, 2023 21:16
mbabadi
mbabadi approved these changes Oct 12, 2023
View reviewed changes
Copy link
Member

@mbabadi mbabadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I like it! :-)

@ordabayevy ordabayevy merged commit da2d3d0 into main Oct 12, 2023
@ordabayevy ordabayevy deleted the cli branch October 12, 2023 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbabadi mbabadi mbabadi approved these changes

Assignees
No one assigned
Labels
awaiting review refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ordabayevy @mbabadi