Override load_from_checkpoint classmethod of TrainingPlan
#91
Conversation
ordabayevy
changed the title
from_checkpoint classmethod to TrainingPlanload_from_checkpoint classmethod of TrainingPlan
cellarium/ml/core/saving.py
Outdated
| if cls.CHECKPOINT_HYPER_PARAMS_KEY in checkpoint: | ||
| cfg = checkpoint[cls.CHECKPOINT_HYPER_PARAMS_KEY] | ||
| else: | ||
| cfg = parser.get_defaults() |
There was a problem hiding this comment.
Is this worth logging a warning?
There was a problem hiding this comment.
Ok, I removed reading defaults to be consistent with an upstream implementation and avoid confusion.
| self._set_hparams(config) | ||
|
|
||
| @classmethod | ||
| @patch("lightning.pytorch.core.saving._load_state", new=_load_state) |
There was a problem hiding this comment.
I just learned something new! This mocking library is pretty awesome! It's funny that it lives in unittest. Is that a rare hack to use mocking for patching actual code, or a commonly used workaround?
There was a problem hiding this comment.
Yeah it is pretty neat, found it on stackexchange.
Is that a rare hack to use mocking for patching actual code, or a commonly used workaround?
Honestly, I don't know. But it seems to do exactly what I want.
| self._set_hparams(config) | ||
|
|
||
| @classmethod | ||
| @patch("lightning.pytorch.core.saving._load_state", new=_load_state) |
There was a problem hiding this comment.
Yeah it is pretty neat, found it on stackexchange.
Is that a rare hack to use mocking for patching actual code, or a commonly used workaround?
Honestly, I don't know. But it seems to do exactly what I want.
cellarium/ml/core/saving.py
Outdated
| if cls.CHECKPOINT_HYPER_PARAMS_KEY in checkpoint: | ||
| cfg = checkpoint[cls.CHECKPOINT_HYPER_PARAMS_KEY] | ||
| else: | ||
| cfg = parser.get_defaults() |
There was a problem hiding this comment.
Ok, I removed reading defaults to be consistent with an upstream implementation and avoid confusion.
| obj = cfg_init.model | ||
|
|
||
| # save the cfg to the :attr:`obj.hparams` to be able to load the model checkpoint | ||
| obj._set_hparams(cfg) |
There was a problem hiding this comment.
Added this to save the config back to the object so that hyperparams are saved if the loaded model is checkpointed again.
Addresses #86