Fix __len__ of IterableDistributedAnnDataCollectionDataset
#93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbabadi
reviewed
Oct 19, 2023
| @@ -336,9 +337,13 @@ def main(args: ArgsType = None) -> None: | |||
| elif isinstance(args, list): | |||
| model_name = args.pop(0) | |||
| elif args is None: | |||
| model_name = sys.argv.pop(1) | |||
| args = sys.argv[1:].copy() | |||
| model_name = args.pop(0) | |||
There was a problem hiding this comment.
here and in other conditions, please assert that args (or argv) is well-formed (e.g. args has at least one element if it is a list, args has "model_name" key if it is a dict or Namespace, etc.) and produce an informative exception message. Also, check that model_name is in REGISTERED_MODELS and if not, produce another informative exception message (e.g. the provided model name "blah blah" is invalid. Valid options are: {list(REGISTERED_MODELS.keys())}).
There was a problem hiding this comment.
Great suggestion!
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
mbabadi
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
lenof iterable dataset should return the number of batches per replica. This fixes the previous bug in the progress bar where it would show the total number of cell as the number of steps per epoch.Another bug that is fixed is running multiple devices with new
cellarium.ml.climodule. Instead of changingsys.argvthis PR copies it and passes it to themodel_cliasargs.Also enabled multi devices testing for scripts (#44).