Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve Blockscout live issues #918

Merged
merged 11 commits into from
Jun 12, 2023
Merged

Resolve Blockscout live issues #918

merged 11 commits into from
Jun 12, 2023

Conversation

rkachowski
Copy link

@rkachowski rkachowski commented Jun 12, 2023

Description

A collection of patches to resolve issues that have occurred since the last upstream merge and deployment.

High db cpu usage

NewContractsCounter runs an expensive query whenever a pod is started + every 30 minutes. This should be very cheap via an index on the transactions table, but the query plan does not use it. Instead this feature is just disabled and new contract count is no longer shown

GraphQL issues

  • Custom graphql queries became very expensive due to db changes, the optimised replacement query lacked pagination support - this has been readded
  • Support for token_id within the token_transfer response has been readded, and backwards compatibility from lists of token ids
    • A single transfer can presumably include multiple token_ids, but it's unclear to what extent this feature is used / supported in external projects
    • The first id within the list of token_ids will be returned should token_id be null

Proxy contract support

Other Changes

  • Modifies deployment workflow to include the deployment sha in the title

Tested

  • Tested locally against rc13 db
    • Asserted that graphql query contains token_id value for erc-721 tokens
    • Can navigate to contract address specified above
    • Application functions without NewContractsCounter being added to supervision tree
    • Saw pagination in graphql response
      "endCursor": "YXJyYXljb25uZWN0aW9uOjI0",
      "hasNextPage": true,
      "hasPreviousPage": false,
      "startCursor": "YXJyYXljb25uZWN0aW9uOjA="
      
  • Ran and passed test suite

Issues

@github-actions
Copy link

github-actions bot commented Jun 12, 2023

Unit Test Results

       6 files  ±0     366 suites   - 1   4m 5s ⏱️ +24s
2 650 tests ±0  2 576 ✔️ ±0  74 💤 ±0  0 ±0 
2 664 runs  ±0  2 588 ✔️ ±0  76 💤 ±0  0 ±0 

Results for commit 59d8965. ± Comparison against base commit 2d7d432.

♻️ This comment has been updated with latest results.

@rkachowski rkachowski changed the title Dhutch/fixes Resolve Blockscout live issues Jun 12, 2023
@rkachowski rkachowski marked this pull request as ready for review June 12, 2023 14:47
@rkachowski rkachowski requested a review from a team June 12, 2023 14:47
@rkachowski rkachowski self-assigned this Jun 12, 2023
@rkachowski rkachowski merged commit fb1d16d into master Jun 12, 2023
@rkachowski rkachowski deleted the dhutch/fixes branch June 12, 2023 15:31
@celo-org celo-org deleted a comment Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants