Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick PRs to 1.3.x branch and release v1.3.0-beta.3 #1491

Merged
merged 4 commits into from
Apr 8, 2021

Conversation

oneeman
Copy link
Contributor

@oneeman oneeman commented Apr 8, 2021

Description

Cherry pick a couple of PRs to the 1.3.x release branch:

Then update the version to v1.3.0-beta.3 which will be tagged as a release.

Other changes

Revert the change in default tx pool GlobalPending value. It was changed to 2048 in v1.3.0-beta.2 due to remaining inefficiencies with large tx pools. However, this is resolved by #1490, so this PR also sets it back to its original value of 4096.

Tested

  • PRs tested separately and approved for master.

gastonponti and others added 3 commits April 8, 2021 14:02
Description
Improve reliability from the ethstats module

The connectionWrapper was cherrypicked from go-ethereum upstream:
ethereum/go-ethereum@82a9e11 (ethereum/go-ethereum#21404)

Other changes
Validator injecting its version to the proxy stats chunk

Tested
Manually in a local testnet

Related issues
Fixes #1395
Fixes #1397
Backwards compatibility
Yes
The decrease to 2048 was due to inefficiencies in the tx pool which have now been fixed, so this sets it back to its original value.
@oneeman oneeman requested a review from a team as a code owner April 8, 2021 20:20
@oneeman oneeman changed the title Cherry-pick PRs to 1.3.x branch Cherry-pick PRs to 1.3.x branch and release v1.3.0-beta.3 Apr 8, 2021
Copy link
Contributor

@gastonponti gastonponti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oneeman oneeman merged commit f34d95a into release/1.3.x Apr 8, 2021
@oneeman oneeman deleted the oneeman/1.3.x-cherry-picks branch April 8, 2021 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants