Fix concurrent map access error when tracing blocks #1822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The logging from these tests slowed them down and cluttered the output of test runs.
Ensure state.StateDB instances are not accessed concurrently.
piersy
requested review from
hbandura,
gastonponti,
mcortesi and
a team
and removed request for
a team,
hbandura and
gastonponti
|
Coverage from tests in coverage: 51.8% of statements across all listed packagescoverage: 65.2% of statements in consensus/istanbul coverage: 43.1% of statements in consensus/istanbul/announce coverage: 56.0% of statements in consensus/istanbul/backend coverage: 0.0% of statements in consensus/istanbul/backend/backendtest coverage: 24.3% of statements in consensus/istanbul/backend/internal/replica coverage: 70.6% of statements in consensus/istanbul/core coverage: 50.0% of statements in consensus/istanbul/db coverage: 0.0% of statements in consensus/istanbul/proxy coverage: 75.3% of statements in consensus/istanbul/uptime coverage: 100.0% of statements in consensus/istanbul/uptime/store coverage: 51.8% of statements in consensus/istanbul/validator coverage: 79.2% of statements in consensus/istanbul/validator/randomCommentID: 13240928d1 |
mcortesi
approved these changes
Feb 15, 2022
Codecov Report
@@ Coverage Diff @@
## master #1822 +/- ##
==========================================
- Coverage 54.24% 54.21% -0.03%
==========================================
Files 673 673
Lines 88989 88991 +2
==========================================
- Hits 48269 48245 -24
- Misses 37079 37106 +27
+ Partials 3641 3640 -1
Continue to review full report at Codecov.
|
piersy
added a commit
that referenced
this pull request
Feb 28, 2022
Fixes #1799 This commit ensures that state.StateDB instances are not accessed concurrently when tracing blocks and also adds an e2e test to verify the fix. It also disables logging from the e2e tests, because the logs slowed the tests down and cluttered the output of test runs. It also updates test node instances to ensure that all rpc api modules are enabled.
piersy
added a commit
that referenced
this pull request
Feb 28, 2022
Fixes #1799 This commit ensures that state.StateDB instances are not accessed concurrently when tracing blocks and also adds an e2e test to verify the fix. It also disables logging from the e2e tests, because the logs slowed the tests down and cluttered the output of test runs. It also updates test node instances to ensure that all rpc api modules are enabled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the concurrent map access error in the ticket linked below.
The problem was that
state.StateDBinstances were being accessed from multiple go-routines, and they are not safe for concurrent use.Tested
Added an e2e test to ensure that the fix is working.
Related issues