Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify HD wallet path based on BIP-44 on Mycelo #1904

Closed
wants to merge 1 commit into from
Closed

Modify HD wallet path based on BIP-44 on Mycelo #1904

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion mycelo/env/accounts.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,8 +233,9 @@ func (accountType *AccountType) UnmarshalText(text []byte) error {
return nil
}

// path is based on https://github.com/bitcoin/bips/blob/master/bip-0044.mediawiki#path-levels
func mustDerivationPath(accountType AccountType, idx int) accounts.DerivationPath {
return hdwallet.MustParseDerivationPath(fmt.Sprintf("m/%d/%d", int(accountType), idx))
return hdwallet.MustParseDerivationPath(fmt.Sprintf("m/44'/%d'/%d'/0/%d", MyceloCT.Int(), int(accountType), idx))
}

// DeriveAccount will derive the account corresponding to (accountType, idx) using the
Expand Down
13 changes: 13 additions & 0 deletions mycelo/env/coin_type.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
package env

// CoinType represents the coin_type based on BIP-44
// Refer to https://github.com/bitcoin/bips/blob/master/bip-0044.mediawiki#path-levels
type CoinType int

// https://github.com/satoshilabs/slips/blob/master/slip-0044.md
// This number is not duplicated in SLIP-0044 and copied from `ChainID` in `cmd/mycelo/templates.go`
var MyceloCT CoinType = 9099000

func (c CoinType) Int() int {
return int(c)
}