Remove minimum client version check

[karlb]

Description

This is the code change to go along with CIP-53.

See also

• removal of minimum client version in contracts

Related issues

• Fixes https://github.com/celo-org/celo-blockchain-planning/issues/19

[akeyless-target-app]

Coverage from tests in ./e2e_test/... for ./consensus/istanbul/... at commit f5af0ac

coverage: 45.9% of statements across all listed packages

coverage:  52.4% of statements in consensus/istanbul
coverage:  41.4% of statements in consensus/istanbul/announce
coverage:  54.7% of statements in consensus/istanbul/backend
coverage:   0.0% of statements in consensus/istanbul/backend/backendtest
coverage:  24.3% of statements in consensus/istanbul/backend/internal/replica
coverage:  51.7% of statements in consensus/istanbul/core
coverage:  45.0% of statements in consensus/istanbul/db
coverage:   0.0% of statements in consensus/istanbul/proxy
coverage:  64.4% of statements in consensus/istanbul/uptime
coverage:  51.8% of statements in consensus/istanbul/validator
coverage:  79.2% of statements in consensus/istanbul/validator/random

CommentID: 11a575a7fe

[github-actions]

Coverage from tests in ./e2e_test/... for ./consensus/istanbul/... at commit d0ffc51

coverage: 48.2% of statements across all listed packages

coverage:  61.3% of statements in consensus/istanbul
coverage:  37.5% of statements in consensus/istanbul/announce
coverage:  54.2% of statements in consensus/istanbul/backend
coverage:   0.0% of statements in consensus/istanbul/backend/backendtest
coverage:  24.3% of statements in consensus/istanbul/backend/internal/replica
coverage:  61.3% of statements in consensus/istanbul/core
coverage:  45.0% of statements in consensus/istanbul/db
coverage:   0.0% of statements in consensus/istanbul/proxy
coverage:  64.4% of statements in consensus/istanbul/uptime
coverage:  51.8% of statements in consensus/istanbul/validator
coverage:  79.2% of statements in consensus/istanbul/validator/random

[github-actions]

Test failures:
TestCallTraceTransactionPrecompileTransfer: tracers api_test.go:734: trace mismatch: have &{Type:CALL From:0x3480C2a78Bc1F86D4D25304AC7E0c9dEda44Cd9F To:0x00000000000000000000000000000000000000fd Input:0x0000000000000000000000005e55aa6ff942be646d81743cf500ef7cb7c46850000000000000000000000000cc0c527989b534774186b87f77bb8e29adb66ef700000000000000000000000000000000000000000000000000000000000003e8 Output:0x0000000000000000000000005e55aa6ff942be646d81743cf500ef7cb7c46850000000000000000000000000cc0c527989b534774186b87f77bb8e29adb66ef700000000000000000000000000000000000000000000000000000000000003e8 Gas:0x4e9c GasUsed:0x2328 Value:0x0 Error: Calls:[{Type:STATICCALL From:0x0000000000000000000000000000000000000000 To:0x000000000000000000000000000000000000ce10 Input:0xdd927233d7e89ade8430819f08bf97a087285824af3351ee12d72a2d132b0c6c0687bfaf Output:0x0000000000000000000000003480c2a78bc1f86d4d25304ac7e0c9deda44cd9f Gas:0x186a0 GasUsed:0x0 Value: Error: Calls:[{Type:DELEGATECALL From:0x000000000000000000000000000000000000ce10 To:0x000000000000000000000000000000000000CE11 Input:0xdd927233d7e89ade8430819f08bf97a087285824af3351ee12d72a2d132b0c6c0687bfaf Output:0x0000000000000000000000003480c2a78bc1f86d4d25304ac7e0c9deda44cd9f Gas:0x0 GasUsed:0x0 Value: Error: Calls:[]}]}]} want &{Type:CALL From:0x3480C2a78Bc1F86D4D25304AC7E0c9dEda44Cd9F To:0x00000000000000000000000000000000000000fd Input:0x0000000000000000000000005e55aa6ff942be646d81743cf500ef7cb7c46850000000000000000000000000cc0c527989b534774186b87f77bb8e29adb66ef700000000000000000000000000000000000000000000000000000000000003e8 Output:0x0000000000000000000000005e55aa6ff942be646d81743cf500ef7cb7c46850000000000000000000000000cc0c527989b534774186b87f77bb8e29adb66ef700000000000000000000000000000000000000000000000000000000000003e8 Gas:0x4e90 GasUsed:0x2328 Value:0x0 Error: Calls:[{Type:STATICCALL From:0x0000000000000000000000000000000000000000 To:0x000000000000000000000000000000000000ce10 Input:0xdd927233d7e89ade8430819f08bf97a087285824af3351ee12d72a2d132b0c6c0687bfaf Output:0x0000000000000000000000003480c2a78bc1f86d4d25304ac7e0c9deda44cd9f Gas:0x186a0 GasUsed:0x0 Value: Error: Calls:[{Type:DELEGATECALL From:0x000000000000000000000000000000000000ce10 To:0x000000000000000000000000000000000000CE11 Input:0xdd927233d7e89ade8430819f08bf97a087285824af3351ee12d72a2d132b0c6c0687bfaf Output:0x0000000000000000000000003480c2a78bc1f86d4d25304ac7e0c9deda44cd9f Gas:0x0 GasUsed:0x0 Value: Error: Calls:[]}]}]}
This test report was produced by the test-summary action.  Made with ❤️ in Cambridge.

[codecov]

Codecov Report

Patch coverage: 65.24% and project coverage change: +0.94 🎉

Comparison is base (71bdbcf) 54.30% compared to head (41ea45c) 55.25%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2026      +/-   ##
==========================================
+ Coverage   54.30%   55.25%   +0.94%     
==========================================
  Files         692      672      -20     
  Lines      115642   113386    -2256     
==========================================
- Hits        62795    62646     -149     
+ Misses      49014    46928    -2086     
+ Partials     3833     3812      -21     

Impacted Files	Coverage Δ
cmd/devp2p/internal/ethtest/transaction.go	0.00% <0.00%> (ø)
cmd/geth/chaincmd.go	0.00% <0.00%> (ø)
cmd/geth/main.go	21.39% <ø> (+0.91%)	⬆️
cmd/geth/usage.go	10.90% <ø> (ø)
cmd/utils/flags.go	2.56% <0.00%> (ø)
consensus/istanbul/utils.go	47.10% <ø> (+1.13%)	⬆️
contracts/currency/currency.go	55.00% <ø> (ø)
contracts/election/election.go	25.00% <ø> (ø)
contracts/epoch_rewards/epoch_rewards.go	88.88% <ø> (ø)
contracts/freezer/freezer.go	70.00% <ø> (ø)
... and 34 more

... and 27 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[palango]

LGTM