fix hd wallet path based on bit44 #2028
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hiroki Yasui <hiroki.yasui@datachain.jp>
|
Coverage from tests in coverage: 49.7% of statements across all listed packagescoverage: 63.2% of statements in consensus/istanbul coverage: 41.8% of statements in consensus/istanbul/announce coverage: 55.8% of statements in consensus/istanbul/backend coverage: 0.0% of statements in consensus/istanbul/backend/backendtest coverage: 24.3% of statements in consensus/istanbul/backend/internal/replica coverage: 62.4% of statements in consensus/istanbul/core coverage: 50.0% of statements in consensus/istanbul/db coverage: 0.0% of statements in consensus/istanbul/proxy coverage: 64.4% of statements in consensus/istanbul/uptime coverage: 51.8% of statements in consensus/istanbul/validator coverage: 79.2% of statements in consensus/istanbul/validator/randomCommentID: f13a6e934a |
|
Also superseeds #1904 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebases the original PR #1904 on current master. Original PR description follows:
Signed-off-by: Hiroki Yasui hiroki.yasui@datachain.jp
Description
This PR is for #1903
For now, HD wallet derivation path is not based on BIP-44 in mycelo. This difference makes key synchronization among other libraries difficult. Proper path must be like
m / purpose' / coin_type' / account' / change / address_index. This is specification.e.g.
"m/44'/60'/0'/0/0"is correct, but current"m/1/0"is not. mycelo codeFor example, developer account keys are generated after running geth nodes with specific mnemonic through mycelo. Then I want to deploy contracts onto celo geth nodes. However it's difficult to generate same address with mnemonic using other libraries like @truffle/hdwallet-provider in truffle-config.json
I made sure same addresses are generated between mycelo and @truffle/hdwallet-provider using the same MNEMONIC.
Related issues