Soloseng/cleanup-legacy-config (#10503)

* update pnpcommon README, release sdks script, combiner deps

* Update packages/phone-number-privacy/common/README.md

Co-authored-by: soloseng <102702451+soloseng@users.noreply.github.com>

* Soloseng/firebase-dep-update (#10468)

* bump firebase version

* format `minInstances` to number

* updated peer dependecy

* Soloseng/fix-test-quota-bypass (#10471)

* enable optional quota bypass during load test.

* moved log to better track failed signers

* increase the range test sessionID

* odis crypto op metering (#10461)

add metering

* Soloseng/loadtest-with-DEK (#10482)

* add option to use DEK in loadtest

* Added monitoring counter for AuthenticationMethod

* randomized phonenumber to avoid replay attempts

* removed ODIS legacy PNP config setters

* clean install

---------

Co-authored-by: alecps <alec@cLabs.co>

packages/celotool/src/lib/env-utils.ts

@@ -111,7 +111,6 @@ export enum envVar {
   ODIS_SIGNER_BLOCKCHAIN_PROVIDER = 'ODIS_SIGNER_BLOCKCHAIN_PROVIDER',
   ODIS_SIGNER_DOMAINS_API_ENABLED = 'ODIS_SIGNER_DOMAINS_API_ENABLED',
   ODIS_SIGNER_PNP_API_ENABLED = 'ODIS_SIGNER_PNP_API_ENABLED',
-  ODIS_SIGNER_LEGACY_PNP_API_ENABLED = 'ODIS_SIGNER_LEGACY_PNP_API_ENABLED',
   ORACLE_DOCKER_IMAGE_REPOSITORY = 'ORACLE_DOCKER_IMAGE_REPOSITORY',
   ORACLE_DOCKER_IMAGE_TAG = 'ORACLE_DOCKER_IMAGE_TAG',
   ORACLE_UNUSED_ORACLE_ADDRESSES = 'ORACLE_UNUSED_ORACLE_ADDRESSES',
@@ -208,7 +207,6 @@ export enum DynamicEnvVar {
   ODIS_SIGNER_AZURE_KEYVAULT_DOMAINS_KEY_LATEST_VERSION = '{{ context }}_ODIS_SIGNER_AZURE_KEYVAULT_DOMAINS_KEY_LATEST_VERSION',
   ODIS_SIGNER_DOMAINS_API_ENABLED = '{{ context }}_ODIS_SIGNER_DOMAINS_API_ENABLED',
   ODIS_SIGNER_PHONE_NUMBER_PRIVACY_API_ENABLED = '{{ context }}_ODIS_SIGNER_PNP_API_ENABLED',
-  ODIS_SIGNER_LEGACY_PHONE_NUMBER_PRIVACY_API_ENABLED = '{{ context }}_ODIS_SIGNER_LEGACY_PNP_API_ENABLED',
   ODIS_SIGNER_DB_HOST = '{{ context }}_ODIS_SIGNER_DB_HOST',
   ODIS_SIGNER_DB_PORT = '{{ context }}_ODIS_SIGNER_DB_PORT',
   ODIS_SIGNER_DB_USERNAME = '{{ context }}_ODIS_SIGNER_DB_USERNAME',

packages/celotool/src/lib/odis.ts

@@ -169,7 +169,6 @@ async function helmParameters(celoEnv: string, context: string) {
     `--set keystore.pnpKeyLatestVersion=${keyVaultConfig.pnpKeyLatestVersion}`,
     `--set keystore.domainsKeyLatestVersion=${keyVaultConfig.domainsKeyLatestVersion}`,
     `--set api.pnpAPIEnabled=${fetchEnv(envVar.ODIS_SIGNER_PNP_API_ENABLED)}`,
-    `--set api.legacyPnpAPIEnabled=${fetchEnv(envVar.ODIS_SIGNER_LEGACY_PNP_API_ENABLED)}`,
     `--set api.domainsAPIEnabled=${fetchEnv(envVar.ODIS_SIGNER_DOMAINS_API_ENABLED)}`,
     `--set blockchainProvider=${fetchEnv(envVar.ODIS_SIGNER_BLOCKCHAIN_PROVIDER)}`,
     `--set blockchainApiKey=${blockchainConfig.blockchainApiKey}`,

packages/helm-charts/odis/templates/signer-deployment.yaml

@@ -52,7 +52,6 @@ spec:
 {{ include "common.env-var" (dict "name" "DOMAINS_LATEST_KEY_VERSION" "dict" .Values.keystore "value_name" "domainsKeyLatestVersion") | indent 12 }}
 {{ include "common.env-var" (dict "name" "DOMAINS_API_ENABLED" "dict" .Values.api "value_name" "domainsAPIEnabled") | indent 12 }}
 {{ include "common.env-var" (dict "name" "PHONE_NUMBER_PRIVACY_API_ENABLED" "dict" .Values.api "value_name" "pnpAPIEnabled") | indent 12 }}
-{{ include "common.env-var" (dict "name" "LEGACY_PHONE_NUMBER_PRIVACY_API_ENABLED" "dict" .Values.api "value_name" "legacyPnpAPIEnabled") | indent 12 }}
             - name: DB_PASSWORD
               valueFrom:
                 secretKeyRef:

packages/phone-number-privacy/signer/README.md

@@ -6,7 +6,6 @@ A service that generates unique partial signatures for blinded messages. Using a
 
 ODIS v2 provides support for three APIs, which need to be explicitly enabled ([see below](#enabling-apis-odis-v2) for configuration info):
 
-- **Legacy PNP API**: retrieve signatures for blinded messages, rate-limited using ODIS v1's scheme, based on an account's transaction history and verification status.
 - **PNP API**: retrieve signatures for blinded messages, rate-limited based on quota purchased on-chain in `OdisPayments.sol`.
 - **Domains API**: retrieve signatures over domains with custom rate-limiting schemes, as defined in more detail in [CIP-40](https://github.com/celo-org/celo-proposals/blob/master/CIPs/cip-0040.md).
 
@@ -25,7 +24,6 @@ You can use the following environment variables to configure the ODIS Signer ser
 
 Each API must be explicitly enabled by setting the following env vars to true (all are false by default):
 
-- `LEGACY_PHONE_NUMBER_PRIVACY_API_ENABLED`
 - `PHONE_NUMBER_PRIVACY_API_ENABLED`
 - `DOMAINS_API_ENABLED`