Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cli can't upvote proposals in upvote stage when other proposals are ready for dequeuing #10064

Closed
martinvol opened this issue Dec 8, 2022 · 2 comments · Fixed by #10704
Closed
Labels

Comments

@martinvol
Copy link
Contributor

Expected Behavior

Any proposal in the upvote stage can be upvoted. Proposals ready for dequeuing should be dequeued when attempting to upvote.

Current Behavior

Assuming these are the the proposals in upvote stage:
(id, upvotes)
#1 0
#2 1
#3 1
#4 1

If the cli tries to upvote #1 it will fail with

Running Checks:
   ✔  0x... is vote signer or registered account
   ✔  1 is an existing proposal
   ✔  1 is in stage Queued
Sending Transaction: upvoteTx... failed: Error: execution reverted: invalid lesser key
    Error: Error: execution reverted: invalid lesser key

If it tries to upvote #2, #3 or #4, it will get:

Retrieving derivation Paths [ 0 ]
Running Checks:
   ✔  0x... is vote signer or registered account
   ✔  2 is an existing proposal
   ✔  2 is in stage Queued
Sending Transaction: upvoteTx... failed: Error: execution reverted: cannot upvote a proposal not in the queue
    Error: Error: execution reverted: cannot upvote a proposal not in the queue
@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2023

This issue is stale and will be closed in 30 days without activity

@github-actions github-actions bot added the stale label Sep 5, 2023
@montera82
Copy link
Contributor

montera82 commented Sep 7, 2023

Picked this up again, and i need more clarity on how to replicate the behavior to help me determine the better solution

Update

Spent some time investigating this, and could not replicate it, it seems this problem is solved.
@martinvol is this ticket still valid?
https://www.loom.com/share/b7fa8f837864470b9267eeaa59562e37?sid=484fcbc8-26ce-48f1-82b6-ad81e32797bb

@github-actions github-actions bot removed the stale label Sep 8, 2023
This was referenced Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants